[Etoys-notify] [JIRA] Commented: (SQ-179) Fix targeting in sliders, buttons and menus

jira at immuexa.com jira at immuexa.com
Tue May 12 16:07:36 EDT 2009

     [ http://tracker.immuexa.com/browse/SQ-179?page=comments#action_34633 ]
Jerome Peace commented on SQ-179:

Hi Scott,

If it helps encourage reviewers, I should mention that the above fix was compiled about the time of the report (2007). It was specifically adapted to work with the 3.8 version I had requested for the purpose. So it is not 5 years old.

There is a good chance it will work without major modification.

I'm available to help with any problems you run into. Just report them here.

As for it not being a bug fix(from the report):

It adds #targetPoint to handMorph and it replaces the ill used " evt hand targetOffset" with either "evt hand targetPoint " or "evt targetPoint"

"evt hand targetOffset" is the cause of the bug. Giving the wrong co-ordinates because the offset is being used as a location not a displacement.

Again users can always learn to live without. But with makes a big difference in ease and possible features.

Squeak was designed to have this feature. It was never (before) implemented effectively. People adapted to living without.

Yours in curiosity and service, --Jerome Peace

> Fix targeting in sliders, buttons and menus
> -------------------------------------------
>          Key: SQ-179
>          URL: http://tracker.immuexa.com/browse/SQ-179
>      Project: squeakland
>         Type: Improvement
>   Components: etoys
>     Reporter: Jerome Peace
>      Fix For: M3: summer beta (july)
>  Attachments: targetOffsetFixes-wiz.6.cs
> Original Estimate: 1 hour, 30 minutes
>         Remaining: 1 hour, 30 minutes
> You can set parameters for sliders and buttons and menus.
> However when it comes to setting targets the menus will usually not offer the option.
> This is a known and pervasive bug.
> http://bugs.squeak.org/view.php?id=6521
> 6521: Target setting doesn't work for buttons and sliders
> Has my run at a fix for the squeakland version of things.
> It also explains why the fix is very valuable. 
> Yoshiki has express concern at the extensiveness of the fixes.
> The way around that is to load the fixes as code and focus on just one piece at a time. I originally started just fixing sliders.
> The original change sets are also available, see the linked reports.
> Particularly look at the parent issue. That will accumulate pointers to other relevant reports.
> Fixes can be tried out in 3.9 and 3.10.2.
> Yours in curiosity and service, --Jerome Peace
> Estimate of time to finish. 
> I have made the fixes and proved them to work in 3.9 and 3.10.2
> The fixes in the report worked in Squeakland/Etoys when I made them.
> The work that remains is for somebody to load them in or load a portion of them in and see if they still work.
> This is not work I can offer to do. If somebody looks into it and has trouble I am willing to solve problems that will lead to getting the work into Olpc/etoys & squeakland versions.
> There is a very good chance that things will work right off the bat since I tried them out once before.
> So my estimate is someone needs to invest about 1 hr to check things out. And give feedback to this report.
> Yours in curiosity and service, --Jerome Peace

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:

More information about the Etoys-notify mailing list